Integrate JSON-Schema-Test-Suite tests#77
Merged
dmarcotte merged 7 commits intokson-org:mainfrom Jan 28, 2025
Merged
Conversation
As of 8ab1c53, `ensure_suite.sh` no longer exists, so reword this comment to remove the misleading note
In preparation for our work to parse and enforce schemas defined in [JsonSchema](https://json-schema.org/), extend our build to pull in the [JSON-Schema-Test-Suite](https://github.com/nst/JSONTestSuite) project in alongside our checkout of the [JsonTestSuite](https://github.com/json-schema-org/JSON-Schema-Test-Suite) project. This commit also refactors the main git utility, `ensureCleanCheckout` into its own class. This isn't strictly necessary, but was done as part of an early draft of this commit, and I like how it separates the Json-agnostic Git code into its own class, so I kept it in. Next up, generating Kson tests from the JSON-Schema-Test-Suite tests...
Was TODONE in 38e9753!
Improve on the work in 17468a3 by refactoring `GitOps.ensureCleanCheckout` into the `CleanGitCheckout` class, giving us a cleaner interface for the clean checkouts these suites require and facilitating improved testing, particularly in `JsonTestSuiteGeneratorTest`, including restoring a more robust version of the integation test that we removed in ecdaab7
Generate `SchemaSuiteTest`, native Kotlin Kson tests, from the [Json Schema Test Suite](https://github.com/json-schema-org/JSON-Schema-Test-Suite) tests. These are currently all disabled (see `schemaTestSuiteExclusionsList`) but will come online as support as Json Schema Support is implemented in Kson.
This handful of tests exercises the "accept everything" schema, so we're trivially compliant and can enable these as our initial Json Schema Suite tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to our JsonTestSuite integration, we now also integrate the JSON-Schema-Test-Suite tests towards our goal of supporting Json Schema in Kson